Add terse links for gradient-based calculation using graph-based collection definition#176
Open
cfrontin wants to merge 14 commits intoNLRWindSystems:developfrom
Open
Add terse links for gradient-based calculation using graph-based collection definition#176cfrontin wants to merge 14 commits intoNLRWindSystems:developfrom
cfrontin wants to merge 14 commits intoNLRWindSystems:developfrom
Conversation
Merge develop changes into main
Update installation instructions
just kidding removed references to WISDEM repo and replaced with renamed NLRWindSystems
…rd into feature/terse_links_for_orbit
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request converts the collection system design representation from a discrete graph variable to a continuous terse_links array to enable gradient-based optimization. The terse_links format is a compact integer array encoding the electrical connection topology as a tree structure, where each turbine's connection target is specified by an array index.
Changes:
- Changed
terse_linksfrom a discrete output to a continuous output in collection system components to support gradient computation - Updated the ORBIT wrapper to accept
terse_linksinstead ofgraphand reconstruct the graph internally - Added partial derivative declarations indicating that
terse_linksis independent of input positions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ard/cost/orbit_wrap.py |
Modified to accept terse_links input instead of discrete graph, added logic to reconstruct graph from terse_links, and declared partials for gradient calculations |
ard/collection/optiwindnet_wrap.py |
Moved terse_links from discrete output to continuous output and added partial declarations marking it as independent of position inputs |
ard/collection/templates.py |
Updated template to define terse_links as a continuous output instead of discrete output |
test/ard/unit/cost/test_orbit_wrap.py |
Updated test connections from graph to terse_links |
test/ard/unit/collection/test_templates.py |
Updated test assertions to check for terse_links in continuous outputs instead of discrete outputs |
test/ard/unit/collection/test_optiwindnet.py |
Updated test assertions to check for terse_links in continuous outputs instead of discrete outputs |
README.md |
Updated documentation URLs to point to NLRWindSystems GitHub organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.